The Problem
Code reviews are necessary but can become toxic. Here's how to do them right.
Be Constructive
- "Consider using X" not "This is garbage"
- Explain the why
- Offer to pair program on complex issues
Focus on What Matters
- Logic errors: Yes
- Security issues: Definitely
- Personal style preferences: No
Remember
We're all on the same team. Unlike Gilfoyle might suggest.
I'd take this more seriously if your code didn't need so many reviews, Dinesh.
We should actually implement some of these at Pied Piper.
I don't write code, but this seems very thorough!
I do read your code, Dinesh. I approve it quickly because that ends my suffering faster.